Add support for Oracle DB in recorder#50090
Merged
bdraco merged 7 commits intohome-assistant:devfrom May 23, 2021
Merged
Conversation
Contributor
probot-home-assistant
Bot
added
core
integration: logbook
integration: recorder
integration: sql
new-feature
small-pr
Member
This change is not related to this PR and should be split into a separate PR. |
Contributor
Author
This reverts commit 0b37293.
Contributor
Author
dgomes
reviewed
May 7, 2021
bdraco
requested changes
May 8, 2021
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
Should be good to go once https://github.com/home-assistant/core/pull/50090/files#r628692103 is addressed
bdraco
approved these changes
May 12, 2021
Member
|
@mciupak Should be good to go once the docs are updated to include Oracle connection strings |
bdraco
reviewed
May 20, 2021
8 tasks
bdraco
approved these changes
May 20, 2021
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
I took care of fixing the conflict and adding the docs
Member
|
Finished retesting. All looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds suport to for Oracle DB to the recorder component. There are 3 commits in this PR:
- 0b37293 updates sqlalchemy to 1.4.12 as this version fixes bug with Identity column for MySQL DBI have tested these changes with SQLite, MySQL, Postrges and of course with Oracle DB. Models were update with Identity column, but I am not sure if it should trigger schema version bump.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: